wasi: Implements wasi_snapshot_preview1.poll_oneoff for relative clock events #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| clockIDRealtime = iota | ||
| // clockIDMonotonic is the clock ID named "monotonic" with sys.Nanotime | ||
| clockIDMonotonic | ||
| // clockIDProcessCputime is the unsupported clock ID named "process_cputime_id" |
There was a problem hiding this comment.
these values are new. mainly, changes in this file are validation only and fix to return ErrnoNotsup on unsupported
|
want to check how go implements sleep also.. #621 |
…k events This implements wasi_snapshot_preview1.poll_oneoff for relative clock events, and in doing so stubs `Nanosleep` which defaults to noop, but can be configured to `time.Sleep`. Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
force-pushed
the
poll-sleep
branch
from
bfaec47 to
664c7a5
Compare
added 2 commits
June 17, 2022 13:56
mathetake
reviewed
Jun 17, 2022
| | sock_recv | ❌ | | | ||
| | sock_send | ❌ | | | ||
| | sock_shutdown | ❌ | | | ||
| | Function | Status | Known Usage | |
There was a problem hiding this comment.
one day we want to have CI to verify that this is actually correct :D
mathetake
reviewed
Jun 17, 2022
|
|
||
| For example, the below ends up calling `wasi_snapshot_preview1.poll_oneoff`: | ||
|
|
||
| ```zig |
mathetake
approved these changes
Jun 17, 2022
|
Thanks for the quick review turnaround @mathetake! |
|
Excellent, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements wasi_snapshot_preview1.poll_oneoff for relative clock events,
and in doing so stubs
Nanosleepwhich defaults to noop, but can be configuredto
time.Sleep.Special thanks to @clarkmcc for the failing test here!
fixes #625